Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11530#discussion_r55343410
--- Diff:
examples/src/main/java/org/apache/spark/examples/streaming/JavaTwitterHashTagJoinSentiments.java
---
@@ -171,5 +171,6 @@ public void call(JavaPairRDD<Double, String>
happinessTopicPairs) {
jssc.start();
jssc.awaitTermination();
+ jssc.close();
--- End diff --
Ah, I just realized I misled you in my comments. For _streaming_ examples,
we should _not_ call `close()` or `stop()`. The correct last call is
`awaitTermination()`. If you back those out, I'll merge this. Sorry about that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
