Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1550#discussion_r15386400
  
    --- Diff: pom.xml ---
    @@ -957,6 +957,30 @@
             <groupId>org.apache.maven.plugins</groupId>
             <artifactId>maven-source-plugin</artifactId>
           </plugin>
    +      <plugin>
    +        <groupId>org.scalastyle</groupId>
    +        <artifactId>scalastyle-maven-plugin</artifactId>
    +        <version>0.4.0</version>
    +        <configuration>
    +          <verbose>false</verbose>
    +          <failOnViolation>true</failOnViolation>
    +          <includeTestSourceDirectory>false</includeTestSourceDirectory>
    +          <failOnWarning>false</failOnWarning>
    +          <sourceDirectory>${basedir}/src/main/scala</sourceDirectory>
    +          
<testSourceDirectory>${basedir}/src/test/scala</testSourceDirectory>
    +          <configLocation>scalastyle-config.xml</configLocation>
    +          <outputFile>scalastyle-output.xml</outputFile>
    +          <outputEncoding>UTF-8</outputEncoding>
    +        </configuration>
    +        <executions>
    +          <execution>
    --- End diff --
    
    is the goal here to make this run when someone runs `mvn package`? It 
didn't seem to do that when I ran it (or maybe it runs them all at the end, I 
just looked after core was compiled?)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to