Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11573#discussion_r55352952
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkQl.scala ---
    @@ -64,6 +85,53 @@ private[sql] class SparkQl(conf: ParserConf = 
SimpleParserConf()) extends Cataly
             val tableIdent = extractTableIdent(nameParts)
             RefreshTable(tableIdent)
     
    +      case Token("TOK_CREATEDATABASE", Token(databaseName, Nil) :: 
createDatabaseArgs) =>
    +        val Seq(
    +          allowExisting,
    --- End diff --
    
    When i see a parameter that is named `allowExists` I think the existence of 
the current table is allowed, and that as a consequence the current create 
table command is going to overwrite the existing table. Why not name this 
`ifNotExists`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to