Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/11534#discussion_r55411807 --- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala --- @@ -17,125 +17,100 @@ package org.apache.spark.storage -import java.io.{File, FileOutputStream, IOException, RandomAccessFile} +import java.io.{FileOutputStream, IOException, RandomAccessFile} import java.nio.ByteBuffer import java.nio.channels.FileChannel.MapMode -import org.apache.spark.Logging +import com.google.common.io.Closeables + +import org.apache.spark.{Logging, SparkConf} import org.apache.spark.util.Utils /** * Stores BlockManager blocks on disk. --- End diff -- Yes, that's right. Thread-safety is ensured by locking at higher levels of the system.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org