Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11403#discussion_r55438073
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/ShuffleExchange.scala
---
@@ -103,16 +101,25 @@ case class ShuffleExchange(
new ShuffledRowRDD(shuffleDependency, specifiedPartitionStartIndices)
}
+ /**
+ * Caches the created ShuffleRowRDD so we can reuse that.
+ */
+ private var shuffleRDD: ShuffledRowRDD = null
+
protected override def doExecute(): RDD[InternalRow] = attachTree(this,
"execute") {
--- End diff --
Naive question, but do we need to cache the result after the `attachTree`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
