Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/11555#issuecomment-194006304
Thanks @cloud-fan for working on it! Overall, it looks good. It will be
great to have more test cases. Like the following
* Multiple window functions are used in a single expression, e.g. `sum(...)
OVER (...) / count(...) OVER (...)`.
* An expression having regular expression and window functions, e.g. `1 + 2
+ Count(...) OVER (...)`.
* A regular agg function used with a window function, e.g. `sum(...) -
sum(...) OVER (...)`.
* `ORDER BY` clauses with `ASC` or `DESC` specified.
Also, maybe we are missing some window functions (like `LEAD` and `LAG`)?
Supported window functions can be found in
https://databricks.com/blog/2015/07/15/introducing-window-functions-in-spark-sql.html.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
