Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11403#discussion_r55453570
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SparkPlanGraph.scala
---
@@ -101,12 +104,15 @@ private[sql] object SparkPlanGraph {
} else {
subgraph.nodes += node
}
+ if (name == "ShuffleExchange" || name == "BroadcastExchange") {
--- End diff --
@nongli, just to make sure that your original comment here was addressed:
were you worried about this pattern being incomplete if we add a new type of
exchange? If that's the case, then the move from `name.endsWith("Exchange")` to
this might make things worse.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
