Github user gatorsmile commented on the pull request:

    https://github.com/apache/spark/pull/11555#issuecomment-194181148
  
    @dilipbiswal and I just had an offline discussion about this. Sorry, to 
mention this at the last minute. 
    
    Adding extra subqueries could be a big issue if the column names are the 
same but the original qualifier are different. For example, we can join two 
tables which have the same column names. Normally, we use different qualifier 
names to differentiate them. Now, if we just replace it by the identical 
subquery name, they will lose the original qualifiers. Then, the generated SQL 
statement will be rejected by the Analyzer due to name ambiguity.
    
    We are facing this issue in multiple SQL generation cases. Please correct 
us if our understanding is wrong. Thanks! @cloud-fan @liancheng 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to