Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/11573#discussion_r55489602
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/AlterTableCommandParser.scala
---
@@ -0,0 +1,410 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.command
+
+import scala.collection.mutable.ArrayBuffer
+
+import org.apache.spark.sql.AnalysisException
+import org.apache.spark.sql.catalyst.TableIdentifier
+import org.apache.spark.sql.catalyst.expressions.{Ascending, Descending}
+import org.apache.spark.sql.catalyst.parser._
+import org.apache.spark.sql.catalyst.plans.logical.LogicalPlan
+import org.apache.spark.sql.execution.datasources._
+import org.apache.spark.sql.types.StructType
+
+
+/**
+ * Helper object to parse alter table commands.
+ */
+object AlterTableCommandParser {
+ import ParserUtils._
+
+ /**
+ * Parse the given node assuming it is an alter table command.
+ */
+ def parse(v1: ASTNode): LogicalPlan = {
+ v1.children match {
+ case (tabName @ Token("TOK_TABNAME", _)) :: restNodes =>
+ val tableIdent: TableIdentifier = extractTableIdent(tabName)
+ val partitionSpec = getClauseOption("TOK_PARTSPEC", v1.children)
+ val partition = partitionSpec.flatMap(parsePartitionSpec)
+ matchAlterTableCommands(v1, restNodes, tableIdent, partition)
+ case _ =>
+ throw new AnalysisException(s"Could not parse alter table command:
'${v1.text}'")
+ }
+ }
+
+ private def cleanAndUnquoteString(s: String): String = {
+ cleanIdentifier(unquoteString(s))
+ }
+
+ private def parsePartitionSpec(node: ASTNode): Option[Map[String,
Option[String]]] = {
+ node match {
+ case Token("TOK_PARTSPEC", partitions) =>
+ val spec = partitions.map {
+ case Token("TOK_PARTVAL", ident :: constant :: Nil) =>
+ (cleanAndUnquoteString(ident.text),
Some(cleanAndUnquoteString(constant.text)))
+ case Token("TOK_PARTVAL", ident :: Nil) =>
+ (cleanAndUnquoteString(ident.text), None)
+ }.toMap
+ Some(spec)
+ case _ => None
+ }
+ }
+
+ private def extractTableProps(node: ASTNode): Map[String,
Option[String]] = {
+ node match {
+ case Token("TOK_TABLEPROPERTIES", propsList) =>
+ propsList.flatMap {
+ case Token("TOK_TABLEPROPLIST", props) =>
+ props.map {
+ case Token("TOK_TABLEPROPERTY", key :: Token("TOK_NULL",
Nil) :: Nil) =>
+ val k = cleanAndUnquoteString(key.text)
+ (k, None)
+ case Token("TOK_TABLEPROPERTY", key :: value :: Nil) =>
+ val k = cleanAndUnquoteString(key.text)
+ val v = cleanAndUnquoteString(value.text)
+ (k, Some(v))
+ }
+ }.toMap
+ case _ =>
+ throw new AnalysisException(
+ s"Expected table properties in alter table command:
'${node.text}'")
+ }
+ }
+
+ // TODO: This method is massive. Break it down. Also, add some
comments...
+ private def matchAlterTableCommands(
+ node: ASTNode,
+ nodes: Seq[ASTNode],
+ tableIdent: TableIdentifier,
+ partition: Option[Map[String, Option[String]]]): LogicalPlan = {
+ nodes match {
+ case rename @ Token("TOK_ALTERTABLE_RENAME", renameArgs) :: _ =>
--- End diff --
If you extract the command from the AST, we can remove the additional input
of course.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
