Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/11534#discussion_r55611895 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -428,77 +458,46 @@ private[spark] class BlockManager( Option( shuffleBlockResolver.getBlockData(blockId.asInstanceOf[ShuffleBlockId]).nioByteBuffer()) } else { - doGetLocal(blockId, asBlockResult = false).asInstanceOf[Option[ByteBuffer]] - } - } - - private def doGetLocal(blockId: BlockId, asBlockResult: Boolean): Option[Any] = { - blockInfoManager.lockForReading(blockId) match { - case None => - logDebug(s"Block $blockId was not found") - None - case Some(info) => - doGetLocal(blockId, info, asBlockResult) + blockInfoManager.lockForReading(blockId) match { + case None => + logDebug(s"Block $blockId was not found") + None + case Some(info) => + Some(doGetLocalBytes(blockId, info)) + } --- End diff -- don't know if we care about the debug message, but a nicer way to write this is: ``` blockInfoManager.lockForReading(blockId).map { info => doGetLocalBytes(blockId, info) } ```
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org