GitHub user dongjoon-hyun opened a pull request:

    https://github.com/apache/spark/pull/11637

    [SPARK-3854] Scala style: require spaces before `{`.

    ## What changes were proposed in this pull request?
    
    Since the opening curly brace, '{', has many usages as discussed in 
[SPARK-3854](https://issues.apache.org/jira/browse/SPARK-3854), this PR adds a 
ScalaStyle rule to prevent '){' pattern  for the following majority pattern and 
fixes the code accordingly. If we enforce this in ScalaStyle from now, it will 
improve the Scala code quality and reduce review time.
    ```
    // Correct:
    if (true) {
      println("Wow!")
    }
    
    // Incorrect:
    if (true){
       println("Wow!")
    }
    ```
    
    ## How was this patch tested?
    
    Pass the Jenkins ScalaStyle test.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dongjoon-hyun/spark SPARK-3854

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/11637.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #11637
    
----
commit a6eef3b9fe0fd72b98b47f163aa61259b61e7e29
Author: Dongjoon Hyun <dongj...@apache.org>
Date:   2016-03-10T18:48:31Z

    [SPARK-3854] Scala style: require spaces before `{`.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to