Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11178#discussion_r55754957
--- Diff: project/SparkBuild.scala ---
@@ -384,18 +384,19 @@ object OldDeps {
lazy val project = Project("oldDeps", file("dev"), settings =
oldDepsSettings)
- def versionArtifact(id: String): Option[sbt.ModuleID] = {
- val fullId = id + "_2.11"
- Some("org.apache.spark" % fullId % "1.2.0")
- }
-
def oldDepsSettings() = Defaults.coreDefaultSettings ++ Seq(
name := "old-deps",
scalaVersion := "2.10.5",
- libraryDependencies := Seq("spark-streaming-mqtt",
"spark-streaming-zeromq",
- "spark-streaming-flume", "spark-streaming-twitter",
- "spark-streaming", "spark-mllib", "spark-graphx",
- "spark-core").map(versionArtifact(_).get intransitive())
+ libraryDependencies := Seq(
+ "spark-streaming-mqtt",
+ "spark-streaming-zeromq",
+ "spark-streaming-flume",
+ "spark-streaming-twitter",
+ "spark-streaming",
+ "spark-mllib",
+ "spark-graphx",
+ "spark-core"
+ ).map(id => "org.apache.spark" % (id + "_2.11") % "1.2.0")
--- End diff --
I'm going to post a larger followup in a few minutes with diffs to explain
this fully, but in a nutshell the GenerateMiMaIgnore was hitting many spurious
errors because it couldn't load / reflect on classes since their dependencies
were missing; pulling in these transitive deps fixes that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
