Github user sameeragarwal commented on a diff in the pull request:
https://github.com/apache/spark/pull/11618#discussion_r55774324
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala
---
@@ -62,6 +63,26 @@ abstract class QueryPlan[PlanType <:
QueryPlan[PlanType]] extends TreeNode[PlanT
}
/**
+ * Infers an additional set of constraints from a given set of equality
constraints.
+ * For e.g., if an operator has constraints of the form (`a = 5`, `a =
b`), this returns an
+ * additional constraint of the form `b = 5`
+ */
+ private def inferAdditionalConstraints(constraints: Set[Expression]):
Set[Expression] = {
+ var inferredConstraints = Set.empty[Expression]
+ constraints.foreach {
+ case eq @ EqualTo(l: Attribute, r: Attribute) =>
+ inferredConstraints ++= (constraints - eq).map(_ transform {
+ case a: Attribute if a.semanticEquals(l) => r
--- End diff --
Just to infer equality based on the expression ids of their attribute
references:
https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Canonicalize.scala#L44-L49.
Is that not necessary in this case?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
