Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/11512#issuecomment-195137045
The signal handler change looks fine to me; I agree with Saisai that the
race would happen very rarely and shouldn't be a problem.
Regarding the change in behavior...
> I'm wondering if we just don't change the behavior for 2.x to report
failed by default
So this would only apply to applications that do `System.exit` explicitly,
right? At this point in time I hope people have stopped doing that, so it
should be fine. A quick grep in Spark code shows that `System.exit` seems to be
used only for error cases, so the change would actually help with that (not
that Spark should be calling `System.exit` itself, but that's a different
problem).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
