Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11178#discussion_r55782966
--- Diff:
tools/src/main/scala/org/apache/spark/tools/GenerateMIMAIgnore.scala ---
@@ -80,20 +79,25 @@ object GenerateMIMAIgnore {
/* Inner classes defined within a private[spark] class or object
are effectively
invisible, so we account for them as package private. */
lazy val indirectlyPrivateSpark = {
- val maybeOuter = className.toString.takeWhile(_ != '$')
--- End diff --
This old code didn't behave so nicely in cases where `className` was an
un-nested companion object. For example, say you have a class named
`org.apache.spark.HeartbeatReceiver$`: this class isn't an inner class and the
old code would have `maybeOuter = "org.apache.spark.HeartbeatReceiver"`, which
might not be a valid class.
The replacement code that I added isn't perfect but fails far less often.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
