Github user viirya commented on the pull request:

    https://github.com/apache/spark/pull/11647#issuecomment-195225504
  
    With latest change:
    
        233 milliseconds
        207 milliseconds
        220 milliseconds
    
    BTW, by completely removing the comparison of canonicalized expression in 
`Expression.semanticEquals`, it can't be faster anymore.
    
    In other words, the logic in `Canonicalize` after this change should be 
unrelated to the time spent on `BooleanSimplification` now. If I am wrong about 
this, please let me know.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to