Github user steveloughran commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11152#discussion_r55810810
  
    --- Diff: docs/monitoring.md ---
    @@ -273,8 +309,8 @@ for a running application, at 
`http://localhost:4040/api/v1`.
         <td>Download the event logs for all attempts of the given application 
as a zip file</td>
       </tr>
       <tr>
    -    <td><code>/applications/[app-id]/[attempt-id]/logs</code></td>
    -    <td>Download the event logs for the specified attempt of the given 
application as a zip file</td>
    +    <td><code>/applications/[app-id]/logs</code></td>
    +    <td>Download the event logs for the application as a zip file</td>
    --- End diff --
    
    OK, now i'm confusing, because the docs at the bottom say appId is 
`appid/attemptid` in yarn, which is true for every other element, which was why 
I adjusted this one. 
    
    I'll try and clarify things more about appId vs attemptId, pull the details 
to the top and then have special mention here. As clearly it managed to confuse 
me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to