GitHub user srowen opened a pull request:

    https://github.com/apache/spark/pull/11657

    [SPARK-13823] [CORE] [STREAMING] [SQL] Always specify Charset in String <-> 
byte[] conversions (and remaining Coverity items)

    ## What changes were proposed in this pull request?
    
    - Fixes calls to `new String(byte[])` or `String.getBytes()` that rely on 
platform default encoding, to use UTF-8
    - Same for `InputStreamReader` and `OutputStreamWriter` constructors
    - Standardizes on UTF-8 everywhere
    - Standardizes specifying the encoding with `StandardCharsets.UTF-8`, not 
the Guava constant or "UTF-8" (which means handling 
`UnuspportedEncodingException`)
    - (also addresses the other remaining Coverity scan issues, which are 
pretty trivial; these are separated into commit 
https://github.com/srowen/spark/commit/1deecd8d9ca986d8adb1a42d315890ce5349d29c 
)
    
    ## How was this patch tested?
    
    Jenkins tests

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/srowen/spark SPARK-13823

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/11657.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #11657
    
----
commit 38b0b843fbde0f71086da1004bf853f1349f7402
Author: Sean Owen <so...@cloudera.com>
Date:   2016-03-09T16:47:54Z

    Always specify character encoding, and use standard UTF-8 symbol, when 
converting strings to/from bytes

commit 1deecd8d9ca986d8adb1a42d315890ce5349d29c
Author: Sean Owen <so...@cloudera.com>
Date:   2016-03-09T16:57:15Z

    Fix remaining valid Coverity warnings

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to