Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/11318#discussion_r55830076
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1217,29 +1217,38 @@ setMethod("[[", signature(x = "DataFrame", i =
"numericOrcharacter"),
#' @rdname subset
#' @name [
-setMethod("[", signature(x = "DataFrame", i = "missing"),
- function(x, i, j, ...) {
- if (is.numeric(j)) {
- cols <- columns(x)
- j <- cols[j]
- }
- if (length(j) > 1) {
- j <- as.list(j)
+setMethod("[", signature(x = "DataFrame"),
+ function(x, i, j, ..., drop=T) {
+ # Perform filtering first if needed
--- End diff --
Maybe for Spark 2.0 we can sacrifice some backwards compatibility and have
the R user convenience as long term benefit?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
