Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11635#discussion_r55903553
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
 ---
    @@ -932,6 +933,33 @@ object PushPredicateThroughGenerate extends 
Rule[LogicalPlan] with PredicateHelp
     }
     
     /**
    + * Push [[Filter]] operators through [[Window]] operators. Parts of the 
predicate that can be pushed
    + * beneath must satisfy three conditions:
    + * 1. involving one and only one column that is part of window 
partitioning key.
    + * 2. Window partitioning key should be just a sequence of 
[[AttributeReference]].
    --- End diff --
    
    I am just reading the way how Hive did the work. Actually, this is also my 
question.
    
    
https://issues.apache.org/jira/secure/attachment/12788757/HIVE-12808.05.patch
    
    In this patch, you can see there are test cases to avoid this case. 
    `Test predicate is not getting pushed down when window has compound 
partition key`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to