Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11658#discussion_r55916721
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/SQLBuilder.scala ---
    @@ -168,11 +176,12 @@ class SQLBuilder(logicalPlan: LogicalPlan, 
sqlContext: SQLContext) extends Loggi
             toSQL(p.right),
             p.condition.map(" ON " + _.sql).getOrElse(""))
     
    -    case p: MetastoreRelation =>
    -      build(
    -        
s"${quoteIdentifier(p.databaseName)}.${quoteIdentifier(p.tableName)}",
    -        p.alias.map(a => s" AS ${quoteIdentifier(a)}").getOrElse("")
    -      )
    +    case SQLTable(database, table, _, sample) =>
    +      val qualifiedName = 
s"${quoteIdentifier(database)}.${quoteIdentifier(table)}"
    +      sample.map { case (lowerBound, upperBound) =>
    --- End diff --
    
    After this change, you can remove [case 
Sample](https://github.com/cloud-fan/spark/blob/gensql/sql/hive/src/main/scala/org/apache/spark/sql/hive/SQLBuilder.scala#L131-L146)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to