Github user liancheng commented on the pull request:

    https://github.com/apache/spark/pull/11677#issuecomment-195718320
  
    Also verified locally in Spark shell.
    
    Before:
    
    ```
    scala> sqlContext range 10 select ('id as 'a, 'id as 'b) groupBy 'b agg 'a
    org.apache.spark.sql.AnalysisException: expression '`a`' is neither present 
in the group by, nor is it an aggregate function. Add to group by or wrap in 
first() (or first_value) if you don't care which value you get.;
      at 
org.apache.spark.sql.execution.QueryExecution.assertAnalyzed(QueryExecution.scala:36)
      at org.apache.spark.sql.Dataset$.newDataFrame(DataFrame.scala:58)
      at org.apache.spark.sql.GroupedData.toDF(GroupedData.scala:58)
      at org.apache.spark.sql.GroupedData.agg(GroupedData.scala:214)
      ... 49 elided
    ```
    
    After:
    
    ```
    scala> sqlContext range 10 select ('id as 'a, 'id as 'b) groupBy 'b agg 'a
    org.apache.spark.sql.AnalysisException: expression '`a`' is neither present 
in the group by, nor is it an aggregate function. Add to group by or wrap in 
first() (or first_value) if you don't care which value you get.;
      at 
org.apache.spark.sql.catalyst.analysis.CheckAnalysis$class.failAnalysis(CheckAnalysis.scala:38)
      at 
org.apache.spark.sql.catalyst.analysis.Analyzer.failAnalysis(Analyzer.scala:50)
      at 
org.apache.spark.sql.catalyst.analysis.CheckAnalysis$$anonfun$checkAnalysis$1.org$apache$spark$sql$catalyst$analysis$CheckAnalysis$class$$anonfun$$checkValidAggregateExpression$1(CheckAnalysis.scala:152)
      at 
org.apache.spark.sql.catalyst.analysis.CheckAnalysis$$anonfun$checkAnalysis$1$$anonfun$apply$4.apply(CheckAnalysis.scala:180)
      at 
org.apache.spark.sql.catalyst.analysis.CheckAnalysis$$anonfun$checkAnalysis$1$$anonfun$apply$4.apply(CheckAnalysis.scala:180)
      at 
scala.collection.mutable.ResizableArray$class.foreach(ResizableArray.scala:59)
      at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:48)
      at 
org.apache.spark.sql.catalyst.analysis.CheckAnalysis$$anonfun$checkAnalysis$1.apply(CheckAnalysis.scala:180)
      at 
org.apache.spark.sql.catalyst.analysis.CheckAnalysis$$anonfun$checkAnalysis$1.apply(CheckAnalysis.scala:50)
      at 
org.apache.spark.sql.catalyst.trees.TreeNode.foreachUp(TreeNode.scala:119)
      at 
org.apache.spark.sql.catalyst.analysis.CheckAnalysis$class.checkAnalysis(CheckAnalysis.scala:50)
      at 
org.apache.spark.sql.catalyst.analysis.Analyzer.checkAnalysis(Analyzer.scala:50)
      at 
org.apache.spark.sql.execution.QueryExecution.assertAnalyzed(QueryExecution.scala:34)
      at org.apache.spark.sql.Dataset$.newDataFrame(DataFrame.scala:58)
      at org.apache.spark.sql.GroupedData.toDF(GroupedData.scala:58)
      at org.apache.spark.sql.GroupedData.agg(GroupedData.scala:214)
      ... 49 elided
    ```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to