Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/1165#issuecomment-50219496
@mateiz There were a couple of correctness issues with the previous code
that my latest commits have fixed (see commit message for more detail). After
fixing these I have traced through each step by hand myself and verified that
the behavior is as expected and wrote new tests to confirm this. If you have
time, I would encourage you (and others) to step through the code as well
(especially in `unrollSafely` and `ensureFreeSpace`) to make sure the amount
we're requesting / ensuring free space for make sense to you.
Let me know if you find anything. Otherwise this is ready from my side.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
