Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11687#discussion_r55955831
  
    --- Diff: python/pyspark/streaming/flume.py ---
    @@ -111,13 +111,9 @@ def func(event):
         @staticmethod
         def _get_helper(sc):
             try:
    -            helperClass = 
sc._jvm.java.lang.Thread.currentThread().getContextClassLoader() \
    -                
.loadClass("org.apache.spark.streaming.flume.FlumeUtilsPythonHelper")
    -            return helperClass.newInstance()
    -        except Py4JJavaError as e:
    -            # TODO: use --jar once it also work on driver
    -            if 'ClassNotFoundException' in str(e.java_exception):
    --- End diff --
    
    Let's still keep this check. For other errors (e.g., the py4j java server 
is down), we should not call `_printErrorMsg` as it's confusing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to