Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/11694#discussion_r56056435
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -318,6 +339,13 @@ object GeneralizedLinearRegression extends
DefaultParamsReadable[GeneralizedLine
/** The variance of the endogenous variable's mean, given the value
mu. */
def variance(mu: Double): Double
+ /** Deviance of (y, mu) pair. */
+ def deviance(y: Double, mu: Double, weight: Double): Double
+
+ /** Akaike's 'An Information Criterion'(AIC) value of the family. */
+ def aic(predictions: RDD[(Double, Double, Double)], deviance: Double,
--- End diff --
* document params, especially `predictions` (y, mu, weight)
* chop down args
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
