Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/10355#discussion_r56136601
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/DecisionTreeClassifierSuite.scala
---
@@ -334,6 +334,51 @@ class DecisionTreeClassifierSuite extends
SparkFunSuite with MLlibTestSparkConte
assert(importances.toArray.forall(_ >= 0.0))
}
+ test("should support all NumericType labels") {
--- End diff --
It's not a major issue, but there is a large amount of code duplication in
all the tests. I know you've already tried to pare it down, but if it's
possible to further reduce it by extracting out some methods, that would be
cleaner.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
