Github user tejasapatil commented on the pull request:
https://github.com/apache/spark/pull/11628#issuecomment-196901467
@srowen : That looks cleaner :)
- Calling `hasNext()` inside `next()` looks somewhat un-conventional to me.
But again, its based on an expectation that all clients would call `hashNext()`
before reading off the iterator which is not guaranteed. I have kept it as is.
- There was bug in `hasNext()` which I have fixed.
`propagateChildException()` needs to be called in the end just before returning
and not at the start. Otherwise the code won't propagate exception in some
cases. The test case added in the PR uncovered that. Its fixed now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
