Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11684#discussion_r56204538
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -274,22 +274,75 @@ case class And(left: Expression, right: Expression)
extends BinaryOperator with
val eval2 = right.gen(ctx)
// The result should be `false`, if any of them is `false` whenever
the other is null or not.
- s"""
- ${eval1.code}
- boolean ${ev.isNull} = false;
- boolean ${ev.value} = false;
+ if (!left.nullable && !right.nullable) {
+ ev.isNull = "false"
+ s"""
+ ${eval1.code}
+ boolean ${ev.value} = false;
- if (!${eval1.isNull} && !${eval1.value}) {
+ if (${eval1.value}) {
+ ${eval2.code}
+ if (${eval2.value}) {
+ ${ev.value} = true;
+ }
+ }
+ """
+ } else {
+ if (!left.nullable) {
--- End diff --
The second and third branch do not look better than the fourth one (also no
performance difference), could you remove that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
