Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11721#discussion_r56263000
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
    @@ -374,12 +374,6 @@ class SparkContext(config: SparkConf) extends Logging 
with ExecutorAllocationCli
           throw new SparkException("An application name must be set in your 
configuration")
         }
     
    -    // System property spark.yarn.app.id must be set if user code ran by 
AM on a YARN cluster
    -    if (master == "yarn" && deployMode == "cluster" && 
!_conf.contains("spark.yarn.app.id")) {
    --- End diff --
    
    Hmm, this was introduced so that people don't try `new SparkContext(new 
SparkConf().setMaster("yarn-cluster"))` and then complain when they get really 
odd error messages.
    
    Is there another way to do this check?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to