Github user jeanlyn commented on the pull request:

    https://github.com/apache/spark/pull/11679#issuecomment-197127323
  
    I think the the metrics of `updatedBlockStatuses` does not updated using 
code like 
    ```
    c.taskMetrics().incUpdatedBlockStatuses(Seq((blockId, status)))
    ```
     in `BlockManager.removeBlock` and the method invoke `removeBlock` when 
removing the blocks cause the problem.
    see:
    
master:https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/storage/BlockManager.scala#L1226-1226
    
branch-1.6:https://github.com/apache/spark/blob/branch-1.6/core/src/main/scala/org/apache/spark/storage/BlockManager.scala#L1108
    
branch-1.5:https://github.com/apache/spark/blob/branch-1.5/core/src/main/scala/org/apache/spark/storage/BlockManager.scala#L1101
    So when the the task end, we can not update the `executorIdToStorageStatus` 
in `StorageStatusListener` correctly. Let me know if my understanding is wrong.
    Forgive me for didn't explain the problem clearly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to