Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1608#discussion_r15438411
  
    --- Diff: external/hbase/pom.xml ---
    @@ -0,0 +1,217 @@
    +<project xmlns="http://maven.apache.org/POM/4.0.0"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
    +   xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
    +      <modelVersion>4.0.0</modelVersion>
    +        <parent>
    +          <groupId>org.apache.spark</groupId>
    +          <artifactId>spark-parent</artifactId>
    +          <version>1.1.0-SNAPSHOT</version>
    +          <relativePath>../../pom.xml</relativePath>
    +        </parent>
    +
    +        <groupId>org.apache.spark</groupId>
    +        <artifactId>spark-hbase_2.10</artifactId>
    +        <properties>
    +           <sbt.project.name>spark-hbase</sbt.project.name>
    +        </properties>
    +        <packaging>jar</packaging>
    +        <name>Spark Project External Flume</name>
    +        <url>http://spark.apache.org/</url>
    +
    +   <dependencies>
    +           <dependency>
    +                   <groupId>org.scalatest</groupId>
    +                   
<artifactId>scalatest_${scala.binary.version}</artifactId>
    +                   <version>2.2.0</version>
    +           </dependency>
    +
    +           <dependency>
    +                   <groupId>com.google.guava</groupId>
    +                   <artifactId>guava</artifactId>
    +                   <version>14.0.1</version>
    +           </dependency>
    +           <dependency>
    +                   <groupId>org.apache.hadoop</groupId>
    +                   <artifactId>hadoop-client</artifactId>
    +                   <version>2.3.0</version>
    --- End diff --
    
    You shouldn't specify versions in the children poms. In fact, you can't, 
since this one in particular has to be overridden by `hadoop.version`. You can 
remove all `<version>` in this file. In fact there is already an 
`hbase.version` defined in the parent, which affects the code examples. You may 
also have to harmonize the examples with the newer HBase.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to