Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11756#discussion_r56291651
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
 ---
    @@ -969,6 +969,14 @@ class JsonSuite extends QueryTest with 
SharedSQLContext with TestJsonData {
           withTempTable("jsonTable") {
             val jsonDF = sqlContext.read.json(corruptRecords)
             jsonDF.registerTempTable("jsonTable")
    +        val jsonDFWithDropMalformed =
    +          sqlContext.read.option("mode", 
"DROPMALFORMED").json(corruptRecords)
    +        
jsonDFWithDropMalformed.registerTempTable("jsonTableWithDropMalformed")
    --- End diff --
    
    Will we persistent JSON options along with data when register table? If 
not, I think this `jsonTableWithDropMalformed` is identical to `jsonTable`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to