Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11745#discussion_r56743896
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
 ---
    @@ -91,6 +92,10 @@ abstract class Optimizer extends 
RuleExecutor[LogicalPlan] {
           SimplifyCasts,
           SimplifyCaseConversionExpressions,
           EliminateSerialization) ::
    +    // Because ColumnPruning is called after PushPredicateThroughProject, 
the predicate push down
    +    // is reversed. This batch is to ensure Filter is pushed below 
Project, if possible.
    +    Batch("Push Predicate Through Project", Once,
    +      PushPredicateThroughProject) ::
    --- End diff --
    
    Put this role in a separate batch is not correct, some other filter push 
down rules depend on this one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to