Github user sameeragarwal commented on a diff in the pull request:
https://github.com/apache/spark/pull/11749#discussion_r56417640
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnarBatch.java
---
@@ -345,15 +358,25 @@ public void setColumn(int ordinal, ColumnVector
column) {
* in this batch will not include this row.
*/
public final void markFiltered(int rowId) {
- assert(filteredRows[rowId] == false);
+ assert(!filteredRows[rowId]);
filteredRows[rowId] = true;
++numRowsFiltered;
}
+ /**
+ * Marks a given column as non-nullable. Any row that has a NULL value
for the corresponding
+ * attribute is filtered out.
+ */
+ public final void filterNullsInColumn(int ordinal) {
+ assert(!nullFilteredColumns.contains(ordinal));
--- End diff --
yes, with the set it's not longer required. Fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
