GitHub user cloud-fan opened a pull request:

    https://github.com/apache/spark/pull/11786

    [SPARK-13976][SQL] do not remove sub-queries added by user when generate SQL

    ## What changes were proposed in this pull request?
    
    We haven't figured out the corrected logical to add sub-queries yet, so we 
should not clear all sub-queries before generate SQL. This PR changed the logic 
to only remove sub-queries above table relation.
    
    TODO: for long term, we should find a way to add sub-queries correctly, so 
that arbitrary logical plans can be converted to SQL string.
    
    
    ## How was this patch tested?
    
    `LogicalPlanToSQLSuite`

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloud-fan/spark bug-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/11786.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #11786
    
----
commit ee5a43739b895708c054558c62263a6a59aa4b1e
Author: Wenchen Fan <wenc...@databricks.com>
Date:   2016-03-17T16:08:16Z

    do not remove sub-queries added by user when generate SQL

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to