Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/11788#discussion_r56618062
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -118,6 +148,18 @@ private[sql] abstract class SparkStrategies extends
QueryPlanner[SparkPlan] {
leftKeys, rightKeys, Inner, BuildLeft, condition,
planLater(left), planLater(right)))
case ExtractEquiJoinKeys(Inner, leftKeys, rightKeys, condition,
left, right)
+ if !conf.preferSortMergeJoin && shouldShuffleHashJoin(left, right)
||
+ !RowOrdering.isOrderable(leftKeys) =>
--- End diff --
this is not part of your pr -- but looking at this reminds me that we
should make sure this is never true (!isOderable) -- keys that cannot be sorted
should just not be join keys.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
