Github user yanboliang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11486#discussion_r56619866
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/RFormula.scala 
---
    @@ -248,6 +248,18 @@ class RFormulaModel private[feature](
           !columnNames.contains($(labelCol)) || schema($(labelCol)).dataType 
== DoubleType,
           "Label column already exists and is not of type DoubleType.")
       }
    +
    +  /**
    +   * Get the original array of labels if exists.
    +   */
    +  private[ml] def getOriginalLabels: Option[Array[String]] = {
    --- End diff --
    
    Should we add a ```IndexToString``` transformer at the end of the 
```PipelineModel```? I think it would be more general. Other functions such as 
```glm``` with "binomial" family should also do the same work.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to