Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/11636#discussion_r56692918 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/BoundAttribute.scala --- @@ -104,3 +104,39 @@ object BindReferences extends Logging { }.asInstanceOf[A] // Kind of a hack, but safe. TODO: Tighten return type when possible. } } + +case class InputReference( + columnOrdinal: Int, dataType: DataType, nullable: Boolean, rowOrdinal: String = "") + extends LeafExpression { + + private val isColumnarStorage: Boolean = rowOrdinal != "" + + private val ordinalString = if (isColumnarStorage) { rowOrdinal } else { columnOrdinal.toString } + + override def toString: String = s"input[$columnOrdinal, ${dataType.simpleString}]" + + override def eval(input: InternalRow): Any = { + null + } + + override def genCode(ctx: CodegenContext, ev: ExprCode): String = { + val javaType = ctx.javaType(dataType) + val value = ctx.getValue(ctx.INPUT_ROW, dataType, ordinalString) + if (ctx.currentVars != null && ctx.currentVars(columnOrdinal) != null) { --- End diff -- We do need this, I think.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org