Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11775#discussion_r56475177
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -205,7 +205,17 @@ case class DataSource(
val hdfsPath = new Path(path)
val fs =
hdfsPath.getFileSystem(sqlContext.sparkContext.hadoopConfiguration)
val qualified = hdfsPath.makeQualified(fs.getUri,
fs.getWorkingDirectory)
- SparkHadoopUtil.get.globPathIfNecessary(qualified)
+ val globPath = SparkHadoopUtil.get.globPathIfNecessary(qualified)
+
+ if (globPath.isEmpty) {
+ throw new AnalysisException(s"Path does not exist: $qualified")
+ }
+ // Sufficient to check head of the globPath seq for non-glob
scenario
+ if (! (SparkHadoopUtil.
--- End diff --
Spacing a breaking here is wrong. You can use string interpolation in the
exception message.
This looks reasonable, but I am not sure whether it's somehow bad to check
this too early and fail if the expected file isn't there at the point this is
checked. It is probably Ok but let's see what tests say
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
