Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/11620#discussion_r56545500
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -549,7 +548,9 @@ trait Params extends Identifiable with Serializable {
* Parameter value checks which do not depend on other parameters are
handled by
* [[Param.validate()]]. This method does not handle input/output
column parameters;
* those are checked during schema validation.
+ * @deprecated Will be removed in 2.1.0. All the checks should be merged
into transformSchema
*/
+ @deprecated("Will be removed in 2.1.0. Checks should be merged into
transformSchema.", "2.0.0")
--- End diff --
Hi @jkbradley have you already started on this? Sorry for the troubling. I
didn't remove the ones in CrossValidator and TrainValidationSplit because I
think it can be handy if we can run some validation before submitting the
paramMap. Let me know if I can help in any way.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
