GitHub user liancheng opened a pull request:

    https://github.com/apache/spark/pull/11820

    [SPARK-14004][SQL][MINOR] AttributeReference and Alias should only use the 
first qualifier to generate SQL strings

    ## What changes were proposed in this pull request?
    
    Current implementations of `AttributeReference.sql` and `Alias.sql` joins 
all available qualifiers, which is logically wrong. But this implementation 
mistake doesn't cause any real SQL generation bugs though, since there is 
always at most one qualifier for any given `AttributeReference` or `Alias`.
    
    This PR fixes this issue by only picking the first qualifiers.
    
    ## How was this patch tested?
    
    (Please explain how this patch was tested. E.g. unit tests, integration 
tests, manual tests)
    
    Existing tests should be enough.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/liancheng/spark spark-14004-single-qualifier

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/11820.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #11820
    
----
commit 1a35c8af86e6d704a47b3398cfb6a3bfc12b7947
Author: Cheng Lian <l...@databricks.com>
Date:   2016-03-18T10:45:51Z

    Only uses the first qualifier to generate SQL string

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to