Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11719#discussion_r56393833
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
    @@ -555,9 +555,9 @@ private[spark] class TaskSetManager(
             // Jump to the next locality level, and reset lastLaunchTime so 
that the next locality
             // wait timer doesn't immediately expire
             lastLaunchTime += localityWaits(currentLocalityIndex)
    -        currentLocalityIndex += 1
    -        logDebug(s"Moving to ${myLocalityLevels(currentLocalityIndex)} 
after waiting for " +
    +        logDebug(s"Moving to ${myLocalityLevels(currentLocalityIndex + 1)} 
after waiting for " +
    --- End diff --
    
    haven't looked closely at this, but could currentLocalityIndex + 1 create 
an index out of bound for myLocalityLevels?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to