Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/10355#discussion_r56465357
--- Diff: mllib/src/main/scala/org/apache/spark/ml/Predictor.scala ---
@@ -49,10 +50,7 @@ private[ml] trait PredictorParams extends Params
validateParams()
// TODO: Support casting Array[Double] and Array[Float] to Vector when
FeaturesType = Vector
SchemaUtils.checkColumnType(schema, $(featuresCol), featuresDataType)
- if (fitting) {
- // TODO: Allow other numeric types
- SchemaUtils.checkColumnType(schema, $(labelCol), DoubleType)
- }
+ if (fitting) SchemaUtils.checkNumericType(schema, $(labelCol))
--- End diff --
Spark style prefers to keep the braces format for if statements. Can you
change it back please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
