Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/11812#issuecomment-198242957
Thanks for this. While I see that normalizing the vectors internally may be
useful, it does change behaviour in the `getVectors` and `findSynonyms`
methods. See my inline comments.
My question is, can this fix be achieved with only the adaptive learning
rate change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
