Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/11684#discussion_r56379211
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -199,7 +199,12 @@ case class Divide(left: Expression, right: Expression)
extends BinaryArithmetic
override def symbol: String = "/"
override def decimalMethod: String = "$div"
- override def nullable: Boolean = true
+ override def nullable: Boolean = (left.nullable ||
+ !(!right.nullable && right.isInstanceOf[Literal] &&
+ ((right.asInstanceOf[Literal].value.isInstanceOf[Decimal] &&
--- End diff --
Since I do not have the benchmark that whose hotspot is related to them, I
removed them in ```Divide``` and ```Remainder```.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
