Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11836#discussion_r56752346
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveCatalog.scala ---
    @@ -85,6 +85,13 @@ private[spark] class HiveCatalog(client: HiveClient) 
extends ExternalCatalog wit
         withClient { getTable(db, table) }
       }
     
    +  /**
    +   * Switch our client to one that belongs to the new session.
    +   */
    +  def newSession(newClient: HiveClient): this.type = {
    --- End diff --
    
    just talked to @yhuai offline. I don't think we need this. The whole reason 
why I did something like this is because `HiveClient` also has session-specific 
stuff, but as long as we use the root `HiveClient` (the first one) then we're 
fine.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to