Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/9474#discussion_r56438348
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/impl/DTStatsAggregator.scala
---
@@ -73,26 +73,31 @@ private[spark] class DTStatsAggregator(
* Flat array of elements.
* Index for start of stats for a (feature, bin) is:
* index = featureOffsets(featureIndex) + binIndex * statsSize
- * Note: For unordered features,
- * the left child stats have binIndex in [0, numBins(featureIndex)
/ 2))
- * and the right child stats in [numBins(featureIndex) / 2),
numBins(featureIndex))
*/
private val allStats: Array[Double] = new Array[Double](allStatsSize)
+ /**
+ * Array of parent node sufficient stats.
--- End diff --
Add note: "This is necessary because stats for the parent node are not
available on the first iteration of tree learning."
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
