Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11701#discussion_r56403772
  
    --- Diff: bin/spark-class ---
    @@ -43,14 +43,14 @@ else
       SPARK_JARS_DIR="${SPARK_HOME}/assembly/target/scala-$SPARK_SCALA_VERSION"
     fi
     
    -if [ ! -d "$SPARK_JARS_DIR" ]; then
    +if [ ! -d "$SPARK_JARS_DIR" ] && [ -z "$SPARK_TESTING" ]; then
       echo "Failed to find Spark jars directory ($SPARK_JARS_DIR)." 1>&2
       echo "You need to build Spark before running this program." 1>&2
       exit 1
    +else
    +  LAUNCH_CLASSPATH="$SPARK_JARS_DIR/*"
     fi
     
    -LAUNCH_CLASSPATH="$SPARK_JARS_DIR/*"
    -
     # Add the launcher build dir to the classpath if requested.
     if [ -n "$SPARK_PREPEND_CLASSES" ]; then
       
LAUNCH_CLASSPATH="${SPARK_HOME}/launcher/target/scala-$SPARK_SCALA_VERSION/classes:$LAUNCH_CLASSPATH"
    --- End diff --
    
    Somehow this is not being picked up (test is failing because the `Main` 
class is not found). Is this path correct for maven too?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to