Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/11673#discussion_r56599894
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1450,7 +1450,9 @@ object CleanupAliases extends Rule[LogicalPlan] {
case c: CreateStructUnsafe if !stop =>
stop = true
c.copy(children = c.children.map(trimNonTopLevelAliases))
- case Alias(child, _) if !stop => child
+ // Only eliminate aliases for named expressions, otherwise we may
turn an `Alias` to a
+ // normal expression and break the type requirement for it.
+ case Alias(child: NamedExpression, _) if !stop => child
--- End diff --
I tried to do it before, but not all logical plans can be accessed in
catalyst, for example, `EvaluatePython`. Should we have a more general
mechanism for declaring operators producing new attributes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
