Github user falaki commented on a diff in the pull request: https://github.com/apache/spark/pull/11724#discussion_r56385761 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVInferSchema.scala --- @@ -108,14 +109,38 @@ private[csv] object CSVInferSchema { } private def tryParseDouble(field: String): DataType = { - if ((allCatch opt field.toDouble).isDefined) { + val doubleTry = allCatch opt field.toDouble --- End diff -- If we encounter a field that is just a long integer value, it is best represented as Decimal. If it has fractions then it must be a double. You are right all numeric types without fractions can be decimal.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org